JS and TS changes for VS Code #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Relates to #144 |
…ion is still all one color essentially
|
@pjlamb12 nice PR - how can I install your PR version into vscode until it gets merged? |
|
Asking for a few people to test this then I'll merge |
|
|
|
Finally any news with the merge? |
|
Might need some README changes if this works for VSCode as well as Sublime, @pjlamb12. |
|
@evanread I used the VSCode Yeoman generator ( |
|
@wesbos You happy with the MR? |
|
looks good - thanks! I will push to VS code as soon as I can remember how... |
|
Are all the brackets supposed to be italics? |
|
nope - I'm getting into VS code so I'll give it a lookski |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some JavaScript and TypeScript visual changes in VS Code. See attached pictures for the before and after.
